Skip to content

Conversation

@hns
Copy link
Member

@hns hns commented Dec 17, 2025

Please review a change to improve selection by host name in the External Specifications page. After trying a list of checkboxes as used in the API summary pages and finding it not a suitable solution, I found that a select/dropdown menu works best for this page.

I also updated @spec tags in java.lang.Character to point to www.unicode.org rather than unicode.org to avoid a unicode.org entry in the host list (other @spec tags use the www.unicode.org host name). The short unicode.org URL is still used elsewhere in the java.lang.Character class, I can update those links to the canonical host name as well if desired.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8309748: Improve host selection in External Specifications page (Enhancement - P3)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28863/head:pull/28863
$ git checkout pull/28863

Update a local copy of the PR:
$ git checkout pull/28863
$ git pull https://git.openjdk.org/jdk.git pull/28863/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 28863

View PR using the GUI difftool:
$ git pr show -t 28863

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28863.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 17, 2025

👋 Welcome back hannesw! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Dec 17, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot added javadoc javadoc-dev@openjdk.org core-libs core-libs-dev@openjdk.org i18n i18n-dev@openjdk.org labels Dec 17, 2025
@openjdk
Copy link

openjdk bot commented Dec 17, 2025

@hns The following labels will be automatically applied to this pull request:

  • core-libs
  • i18n
  • javadoc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 17, 2025
@mlbridge
Copy link

mlbridge bot commented Dec 17, 2025

Webrevs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core-libs core-libs-dev@openjdk.org i18n i18n-dev@openjdk.org javadoc javadoc-dev@openjdk.org rfr Pull request is ready for review

1 participant