8309748: Improve host selection in External Specifications page #28863
+94 −26
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Please review a change to improve selection by host name in the External Specifications page. After trying a list of checkboxes as used in the API summary pages and finding it not a suitable solution, I found that a select/dropdown menu works best for this page.
I also updated
@spectags injava.lang.Characterto point towww.unicode.orgrather thanunicode.orgto avoid aunicode.orgentry in the host list (other@spectags use thewww.unicode.orghost name). The shortunicode.orgURL is still used elsewhere in thejava.lang.Characterclass, I can update those links to the canonical host name as well if desired.Progress
Issue
External Specificationspage (Enhancement - P3)Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28863/head:pull/28863$ git checkout pull/28863Update a local copy of the PR:
$ git checkout pull/28863$ git pull https://git.openjdk.org/jdk.git pull/28863/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 28863View PR using the GUI difftool:
$ git pr show -t 28863Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28863.diff
Using Webrev
Link to Webrev Comment