Skip to content

Conversation

@gredler
Copy link
Contributor

@gredler gredler commented Dec 16, 2025

This method is not used and can be deleted from the entire FontStrike class hierarchy. There was some discussion in 2007 about re-enabling if there were performance benefits, but 20 years have passed and no performance issues have emerged. In fact, the macOS OpenJDK never implemented this method.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-6517125: FontStrike.getGlyphVectorOutline() not used (Enhancement - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28856/head:pull/28856
$ git checkout pull/28856

Update a local copy of the PR:
$ git checkout pull/28856
$ git pull https://git.openjdk.org/jdk.git pull/28856/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 28856

View PR using the GUI difftool:
$ git pr show -t 28856

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28856.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 16, 2025

👋 Welcome back dgredler! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Dec 16, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot added the client client-libs-dev@openjdk.org label Dec 16, 2025
@openjdk
Copy link

openjdk bot commented Dec 16, 2025

@gredler The following label will be automatically applied to this pull request:

  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 16, 2025
@mlbridge
Copy link

mlbridge bot commented Dec 16, 2025

Webrevs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

client client-libs-dev@openjdk.org rfr Pull request is ready for review

1 participant