Skip to content

Conversation

@stefank
Copy link
Member

@stefank stefank commented Dec 16, 2025

In the Valhalla project there's code to restrict nulls in object arrays. In the GC arraycopy barrier we there have to both do null checks in addition to the already existing cast checks. If one of these two failed the code needs to propagate this up through the callers to the code that asked to do the checks. There it will throw the suitable exception. Previously, it was enough to say success or failed, and a boolean was enough. Now we need three states. So the bool was replaced with an OopCopyResult enum.

See: openjdk/valhalla#1792

I propose that we bring this over to the mainline to lower the diff between lworld and the openjdk/jdk.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8373801: Adopt arraycopy OopCopyResult from the lworld branch (Enhancement - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28850/head:pull/28850
$ git checkout pull/28850

Update a local copy of the PR:
$ git checkout pull/28850
$ git pull https://git.openjdk.org/jdk.git pull/28850/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 28850

View PR using the GUI difftool:
$ git pr show -t 28850

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28850.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 16, 2025

👋 Welcome back stefank! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Dec 16, 2025

@stefank This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8373801: Adopt arraycopy OopCopyResult from the lworld branch Reviewed-by: tschatzl 

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 39 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added hotspot hotspot-dev@openjdk.org shenandoah shenandoah-dev@openjdk.org labels Dec 16, 2025
@openjdk
Copy link

openjdk bot commented Dec 16, 2025

@stefank The following labels will be automatically applied to this pull request:

  • hotspot
  • shenandoah

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 16, 2025
@mlbridge
Copy link

mlbridge bot commented Dec 16, 2025

Webrevs

@stefank
Copy link
Member Author

stefank commented Dec 17, 2025

Tier1 testing passes.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Dec 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hotspot hotspot-dev@openjdk.org ready Pull request is ready to be integrated rfr Pull request is ready for review shenandoah shenandoah-dev@openjdk.org

2 participants