8373801: Adopt arraycopy OopCopyResult from the lworld branch #28850
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
In the Valhalla project there's code to restrict nulls in object arrays. In the GC arraycopy barrier we there have to both do null checks in addition to the already existing cast checks. If one of these two failed the code needs to propagate this up through the callers to the code that asked to do the checks. There it will throw the suitable exception. Previously, it was enough to say success or failed, and a boolean was enough. Now we need three states. So the bool was replaced with an OopCopyResult enum.
See: openjdk/valhalla#1792
I propose that we bring this over to the mainline to lower the diff between lworld and the openjdk/jdk.
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28850/head:pull/28850$ git checkout pull/28850Update a local copy of the PR:
$ git checkout pull/28850$ git pull https://git.openjdk.org/jdk.git pull/28850/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 28850View PR using the GUI difftool:
$ git pr show -t 28850Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28850.diff
Using Webrev
Link to Webrev Comment