Skip to content

Conversation

@jerboaa
Copy link
Contributor

@jerboaa jerboaa commented Nov 7, 2025

Please review this test-only enhancement. It creates a regression test for the Amazon ECS setup on cgroups v1 where the parent memory limit isn't visible inside the container and, thus, needs to rely on the cg v1 specific hierarchical_memory_limit token in memory.stat. The proposed test is cg v1 only and needs to be run as root. It's skipped otherwise. It's useful to have when working on refactorings like #27743 so as not to regress.

The other changes are an effort to reduce code duplication in the test code where similar patterns have been used in other container tests.

Testing (all on Linux x86_64):

  • CG version 2, run as root. Engine: docker. Test is skipped.
  • CG version 1, run as root. Engine: docker. Test passes and fails without the product fix of JDK-8370572
  • CG version 1, run as root. Engine: podman. Test passes and fails without the product fix of JDK-8370572
  • CG version 1, run as non-root. Test skipped.
  • GHA, though I don't think this is very useful for this change.

Thoughts?


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8370966: Create regression test for the hierarchical memory limit fix in JDK-8370572 (Enhancement - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28201/head:pull/28201
$ git checkout pull/28201

Update a local copy of the PR:
$ git checkout pull/28201
$ git pull https://git.openjdk.org/jdk.git pull/28201/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 28201

View PR using the GUI difftool:
$ git pr show -t 28201

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28201.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 7, 2025

👋 Welcome back sgehwolf! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Nov 7, 2025

@jerboaa This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8370966: Create regression test for the hierarchical memory limit fix in JDK-8370572 Reviewed-by: shade, syan 

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 34 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added serviceability serviceability-dev@openjdk.org hotspot hotspot-dev@openjdk.org core-libs core-libs-dev@openjdk.org labels Nov 7, 2025
@openjdk
Copy link

openjdk bot commented Nov 7, 2025

@jerboaa The following labels will be automatically applied to this pull request:

  • core-libs
  • hotspot
  • serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@jerboaa jerboaa changed the title 8370966: Create regression test for hierarchical memory limit fix in JDK-8370572 8370966: Create regression test for the hierarchical memory limit fix in JDK-8370572 Nov 7, 2025
@jerboaa jerboaa marked this pull request as ready for review November 7, 2025 17:38
@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 7, 2025
@mlbridge
Copy link

mlbridge bot commented Nov 7, 2025

Webrevs

Copy link
Member

@shipilev shipilev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine, a few nits.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Nov 10, 2025
@openjdk openjdk bot removed the ready Pull request is ready to be integrated label Nov 10, 2025
@jerboaa
Copy link
Contributor Author

jerboaa commented Nov 10, 2025

Thanks for the reviews. Updated the patch.

Copy link
Member

@shipilev shipilev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still good.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Nov 10, 2025
Copy link
Member

@sendaoYan sendaoYan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The touch tests and new tests run passed on my local machine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core-libs core-libs-dev@openjdk.org hotspot hotspot-dev@openjdk.org ready Pull request is ready to be integrated rfr Pull request is ready for review serviceability serviceability-dev@openjdk.org

3 participants