- Notifications
You must be signed in to change notification settings - Fork 6.2k
8370966: Create regression test for the hierarchical memory limit fix in JDK-8370572 #28201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
| 👋 Welcome back sgehwolf! A progress list of the required criteria for merging this PR into |
| @jerboaa This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 34 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
| @jerboaa The following labels will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command. |
Webrevs
|
test/hotspot/jtreg/containers/docker/TestMemoryInvisibleParent.java Outdated Show resolved Hide resolved
shipilev left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine, a few nits.
test/hotspot/jtreg/containers/docker/TestMemoryInvisibleParent.java Outdated Show resolved Hide resolved
| Thanks for the reviews. Updated the patch. |
shipilev left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still good.
sendaoYan left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The touch tests and new tests run passed on my local machine.
Please review this test-only enhancement. It creates a regression test for the Amazon ECS setup on cgroups v1 where the parent memory limit isn't visible inside the container and, thus, needs to rely on the cg v1 specific
hierarchical_memory_limittoken inmemory.stat. The proposed test is cg v1 only and needs to be run as root. It's skipped otherwise. It's useful to have when working on refactorings like #27743 so as not to regress.The other changes are an effort to reduce code duplication in the test code where similar patterns have been used in other container tests.
Testing (all on Linux x86_64):
Thoughts?
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28201/head:pull/28201$ git checkout pull/28201Update a local copy of the PR:
$ git checkout pull/28201$ git pull https://git.openjdk.org/jdk.git pull/28201/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 28201View PR using the GUI difftool:
$ git pr show -t 28201Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28201.diff
Using Webrev
Link to Webrev Comment