8370889: G1: Inline G1PrepareEvacuationTask::sample_card_set_size()

[tschatzl]

Hi all,

please review this simple inlining of a one-liner method that is used once (discounting the check before that line that is actually repeated just a few lines below the call).

Also made the member name a bit more specific.

Testing: gha

Thanks,
Thomas

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8370889: G1: Inline G1PrepareEvacuationTask::sample_card_set_size() (Enhancement - P4)

Reviewers

• Francesco Andreuzzi (@fandreuz - Author)
• Albert Mingkun Yang (@albertnetymk - Reviewer)
• Ivan Walulya (@walulyai - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28046/head:pull/28046
$ git checkout pull/28046

Update a local copy of the PR:
$ git checkout pull/28046
$ git pull https://git.openjdk.org/jdk.git pull/28046/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 28046

View PR using the GUI difftool:
$ git pr show -t 28046

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28046.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back tschatzl! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@tschatzl This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8370889: G1: Inline G1PrepareEvacuationTask::sample_card_set_size() Reviewed-by: fandreuzzi, ayang, iwalulya 

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 8 new commits pushed to the master branch:

• 17fd801: 8370807: G1: Improve region attribute table method naming
• 87a4772: 8366968: Exhaustive switch expression rejected by for not covering all possible values
• f3dfdfa: 8369013: Shenandoah: passive mode should support enabling ShenandoahCardBarrier
• ... and 5 more: https://git.openjdk.org/jdk/compare/2c07214d7c075da5dd4a4e872aef29f58cef2bae...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@tschatzl The following label will be automatically applied to this pull request:

• hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (14e6e2b2)

[tschatzl]

Thanks @albertnetymk @walulyai @fandreuz for your reviews
/integrate

[openjdk]

Going to push as commit c47ea12.
Since your change was applied there have been 35 commits pushed to the master branch:

• c6cc7a7: 8368178: Add specialization of SequencedCollection methods to standard list factories
• fc5df4a: 8370465: Right to Left Orientation Issues with MenuItem Component
• 4f9f086: 8224852: JVM crash on watched field access from native code
• ... and 32 more: https://git.openjdk.org/jdk/compare/2c07214d7c075da5dd4a4e872aef29f58cef2bae...master

Your commit was automatically rebased without conflicts.

[openjdk]

@tschatzl Pushed as commit c47ea12.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.