Skip to content

8370852: Test sun/security/ssl/SSLLogger/DebugPropertyValuesTest.java fails after JDK-8369995 #28045

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 4 commits into from
Closed

8370852: Test sun/security/ssl/SSLLogger/DebugPropertyValuesTest.java fails after JDK-8369995 #28045

wants to merge 4 commits into from
+34 −27

Conversation

@myankelev
Copy link
Member

@myankelev myankelev commented Oct 29, 2025 •
edited by openjdk bot
Loading

Updated test to require ssl,keymanager, as it changed from keymanager.

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8370852: Test sun/security/ssl/SSLLogger/DebugPropertyValuesTest.java fails after JDK-8369995 (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28045/head:pull/28045
$ git checkout pull/28045

Update a local copy of the PR:
$ git checkout pull/28045
$ git pull https://git.openjdk.org/jdk.git pull/28045/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 28045

View PR using the GUI difftool:
$ git pr show -t 28045

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28045.diff

Using Webrev

Link to Webrev Comment
@bridgekeeper
Copy link

bridgekeeper bot commented Oct 29, 2025

👋 Welcome back myankelevich! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.
@openjdk
Copy link

openjdk bot commented Oct 29, 2025 •
edited
Loading

@myankelev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8370852: Test sun/security/ssl/SSLLogger/DebugPropertyValuesTest.java fails after JDK-8369995 Reviewed-by: coffeys, wetmore

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 20 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.
@openjdk openjdk bot changed the title JDK-8370852: Test sun/security/ssl/SSLLogger/DebugPropertyValuesTest.java fails after JDK-8369995 8370852: Test sun/security/ssl/SSLLogger/DebugPropertyValuesTest.java fails after JDK-8369995 Oct 29, 2025
@openjdk openjdk bot added the security security-dev@openjdk.org label Oct 29, 2025
@openjdk
Copy link

openjdk bot commented Oct 29, 2025 •
edited
Loading

@myankelev The following label will be automatically applied to this pull request:

  • security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.
@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 29, 2025
@mlbridge
Copy link

mlbridge bot commented Oct 29, 2025 •
edited
Loading

Webrevs
turbanoff
turbanoff reviewed Oct 30, 2025
View reviewed changes
coffeys
coffeys reviewed Oct 30, 2025
View reviewed changes
test/jdk/sun/security/ssl/SSLLogger/DebugPropertyValuesTest.java

/**
* @test
* @bug 8350582 8340312
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no bug ID should be inserted for test only fixes (AFAIK)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this case I didn't put the current bug ID (test only one), only the product bug id which caused the error to occur. So I believe it's justified in this case.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah, I see - yes, that seems fine then
mpdonova
mpdonova reviewed Oct 30, 2025
View reviewed changes
test/jdk/sun/security/ssl/SSLLogger/DebugPropertyValuesTest.java
List.of("Produced ClientHello handshake message",
"supported_versions"));
debugMessages.put("keymanager", List.of("choosing key:"));
debugMessages.put("keymanager", List.of("Choosing key:"));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this what caused the test to fail? everything else looks like formatting changes.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it was changed in JDK-8369995
coffeys
coffeys approved these changes Oct 30, 2025
View reviewed changes
Copy link
Contributor

@coffeys coffeys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes look good to me
test/jdk/sun/security/ssl/SSLLogger/DebugPropertyValuesTest.java

/**
* @test
* @bug 8350582 8340312
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah, I see - yes, that seems fine then
@openjdk openjdk bot added the ready Pull request is ready to be integrated label Oct 30, 2025
bradfordwetmore
bradfordwetmore approved these changes Oct 30, 2025
View reviewed changes
Copy link
Contributor

@bradfordwetmore bradfordwetmore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Took way to long to figure out that a capital letter changed in the SSL debug output, and that was causing the problem. :)

Thank you for cleaning up the formatting. Having lines <=80 sure helps with side/side comparisons like here in github.

LGTM.
@myankelev
Copy link
Member Author

Thank you for your reviews!
@myankelev
Copy link
Member Author

/integrate
@openjdk
Copy link

openjdk bot commented Oct 31, 2025

Going to push as commit 4ca88aa.
Since your change was applied there have been 37 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.
@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 31, 2025
@openjdk openjdk bot closed this Oct 31, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 31, 2025
@openjdk
Copy link

openjdk bot commented Oct 31, 2025

@myankelev Pushed as commit 4ca88aa.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integrated Pull request has been integrated security security-dev@openjdk.org

5 participants

@myankelev @turbanoff @coffeys @bradfordwetmore @mpdonova