8370804: G1: Make G1HeapRegionAttr::remset_is_tracked() conform to coding style

[tschatzl]

Hi all,

please fix several places where the remset_is_tracked getter and related identifiers do not fit hotspot style, recommending the verb as first part.

Testing: gha

(Please note the dependency on #28038)

Thanks,
Thomas

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8370804: G1: Make G1HeapRegionAttr::remset_is_tracked() conform to coding style (Enhancement - P4)

Reviewers

• Ivan Walulya (@walulyai - Reviewer)
• Stefan Johansson (@kstefanj - Reviewer) Review applies to 3367eb0a
• Francesco Andreuzzi (@fandreuz - Author) Review applies to 865d37e7
• Albert Mingkun Yang (@albertnetymk - Reviewer) Review applies to 865d37e7

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28039/head:pull/28039
$ git checkout pull/28039

Update a local copy of the PR:
$ git checkout pull/28039
$ git pull https://git.openjdk.org/jdk.git pull/28039/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 28039

View PR using the GUI difftool:
$ git pr show -t 28039

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28039.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back tschatzl! A progress list of the required criteria for merging this PR into pr/28038 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@tschatzl This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8370804: G1: Make G1HeapRegionAttr::remset_is_tracked() conform to coding style Reviewed-by: iwalulya, sjohanss, fandreuzzi, ayang 

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

• d565c45: 8370261: Test runtime/NMT/NMTPrintMallocSiteOfCorruptedMemory.java timed out
• 5096dc8: 8368739: [AIX] java/net/httpclient/http3/H3SimpleGet.java#useNioSelector and #with-continuations fail

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@tschatzl The following label will be automatically applied to this pull request:

• hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 02: Full (7a68ed17)
• 01: Full - Incremental (865d37e7)
• 00: Full (3367eb0a)

[kstefanj]

Looks good, but please change to const bool as noted.

[tschatzl]

Fine with me.

[openjdk-notifier]

The parent pull request that this pull request depends on has now been integrated and the target branch of this pull request has been updated. This means that changes from the dependent pull request can start to show up as belonging to this pull request, which may be confusing for reviewers. To remedy this situation, simply merge the latest changes from the new target branch into this pull request by running commands similar to these in the local repository for your personal fork:

git checkout submit/8370804-remset-is-tracked-style git fetch https://git.openjdk.org/jdk.git master git merge FETCH_HEAD # if there are conflicts, follow the instructions given by git merge git commit -m "Merge master" git push

[openjdk]

@tschatzl this pull request can not be integrated into master due to one or more merge conflicts. To resolve these merge conflicts and update this pull request you can run the following commands in the local repository for your personal fork:

git checkout submit/8370804-remset-is-tracked-style git fetch https://git.openjdk.org/jdk.git master git merge FETCH_HEAD # resolve conflicts and follow the instructions given by git merge git commit -m "Merge master" git push

[openjdk]

⚠️ @tschatzl This pull request contains merges that bring in commits not present in the target repository. Since this is not a "merge style" pull request, these changes will be squashed when this pull request in integrated. If this is your intention, then please ignore this message. If you want to preserve the commit structure, you must change the title of this pull request to Merge <project>:<branch> where <project> is the name of another project in the OpenJDK organization (for example Merge jdk:master).

[walulyai]

Still good!

[tschatzl]

Thanks @walulyai @albertnetymk @kstefanj @fandreuz for your reviews
/integrate

[openjdk]

Going to push as commit 87e5341.
Since your change was applied there have been 2 commits pushed to the master branch:

• d565c45: 8370261: Test runtime/NMT/NMTPrintMallocSiteOfCorruptedMemory.java timed out
• 5096dc8: 8368739: [AIX] java/net/httpclient/http3/H3SimpleGet.java#useNioSelector and #with-continuations fail

Your commit was automatically rebased without conflicts.

[openjdk]

@tschatzl Pushed as commit 87e5341.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.