Skip to content

Conversation

@lmesnik
Copy link
Member

@lmesnik lmesnik commented Oct 28, 2025

The MainWrapper used test thread factory has generated lambda method. So the AbsentInformationException is expected. The actual source path is not checked.

Tested by run mlvm tests with and without test thread factory.

Also
jdk/test/lib/thread/TestThreadFactory.java
updated to provide TestThreadFactory. isTestThreadFactorySet()
that could be used by tests instead of checking property "test.thread.factory" directly.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8370846: Support execution of mlvm testing with test thread factory (Sub-task - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28028/head:pull/28028
$ git checkout pull/28028

Update a local copy of the PR:
$ git checkout pull/28028
$ git pull https://git.openjdk.org/jdk.git pull/28028/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 28028

View PR using the GUI difftool:
$ git pr show -t 28028

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28028.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 28, 2025

👋 Welcome back lmesnik! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Oct 28, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot added the hotspot-compiler hotspot-compiler-dev@openjdk.org label Oct 28, 2025
@openjdk
Copy link

openjdk bot commented Oct 28, 2025

@lmesnik The following label will be automatically applied to this pull request:

  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 28, 2025
@mlbridge
Copy link

mlbridge bot commented Oct 28, 2025

Webrevs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hotspot-compiler hotspot-compiler-dev@openjdk.org rfr Pull request is ready for review

1 participant