8370726: GenShen: Misplaced assertion that old referent is marked during young collection

[earthling-amzn]

Recently introduced assertion is too strong:

# # A fatal error has been detected by the Java Runtime Environment: # # Internal Error (/codebuild/output/src2096/src/s3/00/src/hotspot/share/gc/shenandoah/shenandoahReferenceProcessor.cpp:332), pid=1373, tid=1375 # Error: Marking should be complete for object 0x00000007ffc029b0 in the Old generation 

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8370726: GenShen: Misplaced assertion that old referent is marked during young collection (Bug - P4)

Reviewers

• Xiaolong Peng (@pengxiaolong - Committer)
• Y. Srinivas Ramakrishna (@ysramakrishna - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28026/head:pull/28026
$ git checkout pull/28026

Update a local copy of the PR:
$ git checkout pull/28026
$ git pull https://git.openjdk.org/jdk.git pull/28026/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 28026

View PR using the GUI difftool:
$ git pr show -t 28026

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28026.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back wkemper! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@earthling-amzn This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8370726: GenShen: Misplaced assertion that old referent is marked during young collection Reviewed-by: xpeng, ysr 

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 88 new commits pushed to the master branch:

• c49a94b: 8370572: Cgroups hierarchical memory limit is not honored after JDK-8322420
• 414e728: 8370141: [macOS] Crash after PrinterJob ends when Graphics.create() is used.
• 4b31511: 8370160: NumericShaper allows illegal ranges
• ... and 85 more: https://git.openjdk.org/jdk/compare/470eedb1e9d67058ff8d67a5b0c2250d9f9b3fa5...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@earthling-amzn The following labels will be automatically applied to this pull request:

• hotspot-gc
• shenandoah

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (bcc2f8a0)

[pengxiaolong]

Looks good, thanks! Many of our performance test pipelines failed due to this assert.

[ysramakrishna]

🚢

[earthling-amzn]

/integrate

[openjdk]

Going to push as commit c69e0eb.
Since your change was applied there have been 89 commits pushed to the master branch:

• 566aa12: 8370971: Problemlist jdkDoctypeBadcharsCheck.java and jdkCheckHtml.java
• c49a94b: 8370572: Cgroups hierarchical memory limit is not honored after JDK-8322420
• 414e728: 8370141: [macOS] Crash after PrinterJob ends when Graphics.create() is used.
• ... and 86 more: https://git.openjdk.org/jdk/compare/470eedb1e9d67058ff8d67a5b0c2250d9f9b3fa5...master

Your commit was automatically rebased without conflicts.

[openjdk]

@earthling-amzn Pushed as commit c69e0eb.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.