- Notifications
You must be signed in to change notification settings - Fork 6.1k
8370578: SystemMapTest.java#normal fails intermittendly on macOS aarch64 #28025
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
| 👋 Welcome back stooke! A progress list of the required criteria for merging this PR into |
| @stooke This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 35 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@tstuefe, @plummercj, @sspitsyn) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
Webrevs
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
| Arguably, this is simple enough to fall under the trivial rule, but lets wait for other reviewers a bit. |
test/hotspot/jtreg/serviceability/dcmd/vm/SystemMapTestBase.java Outdated Show resolved Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
| @tstuefe @plummercj @sspitsyn thanks for the reviews. |
| /integrate |
This PR addresses JDK-8370578
Under certain circumstances, OpenJDK on macOS maps the hsperf segment private instead of shared; one of those cases is hit during the tier1 tests, which test for that.
This PR allows for shared or private mapping; the purpose of the intermittently failing test is to test System.map implementation, not JDK internals.
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28025/head:pull/28025$ git checkout pull/28025Update a local copy of the PR:
$ git checkout pull/28025$ git pull https://git.openjdk.org/jdk.git pull/28025/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 28025View PR using the GUI difftool:
$ git pr show -t 28025Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28025.diff
Using Webrev
Link to Webrev Comment