Skip to content

Conversation

@stooke
Copy link
Contributor

@stooke stooke commented Oct 28, 2025

This PR addresses JDK-8370578

Under certain circumstances, OpenJDK on macOS maps the hsperf segment private instead of shared; one of those cases is hit during the tier1 tests, which test for that.

This PR allows for shared or private mapping; the purpose of the intermittently failing test is to test System.map implementation, not JDK internals.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8370578: SystemMapTest.java#normal fails intermittendly on macOS aarch64 (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28025/head:pull/28025
$ git checkout pull/28025

Update a local copy of the PR:
$ git checkout pull/28025
$ git pull https://git.openjdk.org/jdk.git pull/28025/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 28025

View PR using the GUI difftool:
$ git pr show -t 28025

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28025.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 28, 2025

👋 Welcome back stooke! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Oct 28, 2025

@stooke This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8370578: SystemMapTest.java#normal fails intermittendly on macOS aarch64 Reviewed-by: cjplummer, sspitsyn, stuefe 

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 35 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@tstuefe, @plummercj, @sspitsyn) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the serviceability serviceability-dev@openjdk.org label Oct 28, 2025
@openjdk
Copy link

openjdk bot commented Oct 28, 2025

@stooke The following label will be automatically applied to this pull request:

  • serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@stooke stooke marked this pull request as ready for review October 29, 2025 13:51
@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 29, 2025
@mlbridge
Copy link

mlbridge bot commented Oct 29, 2025

Webrevs

Copy link
Member

@tstuefe tstuefe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Oct 29, 2025
@tstuefe
Copy link
Member

tstuefe commented Oct 29, 2025

Arguably, this is simple enough to fall under the trivial rule, but lets wait for other reviewers a bit.

@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 29, 2025
@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 29, 2025
@openjdk openjdk bot added the ready Pull request is ready to be integrated label Oct 29, 2025
Copy link
Contributor

@sspitsyn sspitsyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@stooke
Copy link
Contributor Author

stooke commented Oct 30, 2025

@tstuefe @plummercj @sspitsyn thanks for the reviews.

@stooke
Copy link
Contributor Author

stooke commented Oct 30, 2025

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Oct 30, 2025
@openjdk
Copy link

openjdk bot commented Oct 30, 2025

@stooke
Your change (at version e66b02f) is now ready to be sponsored by a Committer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready Pull request is ready to be integrated rfr Pull request is ready for review serviceability serviceability-dev@openjdk.org sponsor Pull request is ready to be sponsored

4 participants