- Notifications
You must be signed in to change notification settings - Fork 6.1k
4397513: Misleading "interface method" in InvocationHandler specification #28024
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…ng for "method" parameter
| 👋 Welcome back liach! A progress list of the required criteria for merging this PR into |
| @liach This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 30 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
| * proxy interface that the proxy class inherits the method through. | ||
| * the method invoked on the proxy instance; the declaring | ||
| * class of the {@code Method} object may be a proxy interface, | ||
| * one of their superinterfaces, or the {@code Object} class |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Jai, the term "proxy interface" is defined in java.lang.reflect.Proxy, together with "proxy instance":
A proxy class is a class created at runtime that implements a specified
list of interfaces, known as proxy interfaces. A proxy instance
is an instance of a proxy class.
So I believe the term "proxy interface" makes sense when you have a "proxy instance" in the context.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for quoting that text - you are right, that term is already specified, so the changes you have here looks good to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this wording looks okay.
| Thanks for the reviews! /integrate |
| Going to push as commit a2196e2.
Your commit was automatically rebased without conflicts. |
Update occurrences of the not-exactly-correct "interface method" to "invoked method" because 3 Object methods are proxied too. In addition, update the description about the declaring class of the method to be more accurate so that it doesn't clash with the "duplicate method" section in Proxy.
Progress
Issues
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28024/head:pull/28024$ git checkout pull/28024Update a local copy of the PR:
$ git checkout pull/28024$ git pull https://git.openjdk.org/jdk.git pull/28024/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 28024View PR using the GUI difftool:
$ git pr show -t 28024Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28024.diff
Using Webrev
Link to Webrev Comment