Skip to content

Conversation

@liach
Copy link
Member

@liach liach commented Oct 28, 2025

Update occurrences of the not-exactly-correct "interface method" to "invoked method" because 3 Object methods are proxied too. In addition, update the description about the declaring class of the method to be more accurate so that it doesn't clash with the "duplicate method" section in Proxy.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change requires CSR request JDK-8370457 to be approved

Issues

  • JDK-4397513: Misleading "interface method" in InvocationHandler specification (Bug - P4)
  • JDK-8370457: Misleading "interface method" in InvocationHandler specification (CSR)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28024/head:pull/28024
$ git checkout pull/28024

Update a local copy of the PR:
$ git checkout pull/28024
$ git pull https://git.openjdk.org/jdk.git pull/28024/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 28024

View PR using the GUI difftool:
$ git pr show -t 28024

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28024.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 28, 2025

👋 Welcome back liach! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Oct 28, 2025

@liach This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

4397513: Misleading "interface method" in InvocationHandler specification Reviewed-by: alanb, jpai 

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 30 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added csr Pull request needs approved CSR before integration core-libs core-libs-dev@openjdk.org labels Oct 28, 2025
@openjdk
Copy link

openjdk bot commented Oct 28, 2025

@liach The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 28, 2025
@mlbridge
Copy link

mlbridge bot commented Oct 28, 2025

Webrevs

@liach liach changed the title 4397513: (reflect) InvocationHandler.invoke javadoc slightly misleading for "method" parameter 4397513 Oct 28, 2025
@openjdk openjdk bot changed the title 4397513 4397513: Misleading "interface method" in InvocationHandler specification Oct 28, 2025
* proxy interface that the proxy class inherits the method through.
* the method invoked on the proxy instance; the declaring
* class of the {@code Method} object may be a proxy interface,
* one of their superinterfaces, or the {@code Object} class
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello Chen, would it be better to word that latter part of the sentence as:

the declaring class of the {@code Method} will either be one of the interfaces implemented by the proxy instance, or one of their super interfaces, or the {@code Object} class.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Jai, the term "proxy interface" is defined in java.lang.reflect.Proxy, together with "proxy instance":

A proxy class is a class created at runtime that implements a specified
list of interfaces, known as proxy interfaces. A proxy instance
is an instance of a proxy class.

So I believe the term "proxy interface" makes sense when you have a "proxy instance" in the context.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for quoting that text - you are right, that term is already specified, so the changes you have here looks good to me.

Copy link
Contributor

@AlanBateman AlanBateman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this wording looks okay.

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed csr Pull request needs approved CSR before integration labels Oct 29, 2025
@liach
Copy link
Member Author

liach commented Oct 30, 2025

Thanks for the reviews!

/integrate

@openjdk
Copy link

openjdk bot commented Oct 30, 2025

Going to push as commit a2196e2.
Since your change was applied there have been 41 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 30, 2025
@openjdk openjdk bot closed this Oct 30, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 30, 2025
@openjdk
Copy link

openjdk bot commented Oct 30, 2025

@liach Pushed as commit a2196e2.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core-libs core-libs-dev@openjdk.org integrated Pull request has been integrated

3 participants