COLL/UCC: Fix aborting with SIGSEGV when persistent request is failed #13440
+34 −30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
devreal previously approved these changes Oct 15, 2025
bosilca previously approved these changes Oct 15, 2025
| This requirements (aka |
Sergei-Lebedev approved these changes Oct 16, 2025
bosilca approved these changes Oct 16, 2025
| Please squash. |
Signed-off-by: Kento Hasegawa <hasegawa.kento@fujitsu.com>
mentOS31 force-pushed the coll_ucc_fix_initialization branch from 109ab06 to 4b1b9a9 Compare | Thank you for your comment and reviews. |
| Would it be possible to create the corresponding PR for 5.x ? |
| Yes, we will create the corresponding PR for the 5.x version. |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
What
When non-blocking or persistent request is failed, MPI_Wait() aborts with SIGSEGV because .req_mpi_object.comm is NULL.
The ompi_errhandler_request_invoke() from the MPI_Wait() causes SIGSEGV by accessing
.req_mpi_object.comm->error_handler.How
Initialize .req_mpi_object.comm in COLL_UCC_GET_REQ() and COLL_UCC_GET_REQ_PERSISTENT() in coll_ucc_common.h.