- Notifications
You must be signed in to change notification settings - Fork 101
NGINX App Protect OTel syslog processor #1262
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
✅ All required contributors have signed the F5 CLA for this PR. Thank you! |
I have hereby read the F5 CLA and agree to its terms |
c3c63df
to 5f92180
Compare 0139f27
to e8085c2
Compare There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR looks good just have a few additional comments.
- Could we actually rename the processor to
securityviolationsprocessor
?syslogprocessor
seems too generic since it wont be able to be used for other syslog messages that have a different message format - Could we add benchmark tests as well similar to these ones? https://github.com/nginx/agent/blob/main/internal/collector/logsgzipprocessor/processor_benchmark_test.go
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry @devbgv I think we missed some variables that need to renamed
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@ ## main #1262 +/- ## ========================================== + Coverage 85.00% 85.01% +0.01% ========================================== Files 100 102 +2 Lines 14528 14878 +350 ========================================== + Hits 12349 12649 +300 - Misses 1716 1753 +37 - Partials 463 476 +13
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
Proposed changes
Introduce a syslog log processor that parses RFC 3164‑formatted log lines and enriches them with structured attributes such as timestamp, hostname, app name, and severity.
Register the processor in internal/collector/factories so it can be used in the agent’s processing pipeline.
Add the github.com/leodido/go-syslog/v4 dependency and wire it into the build.
Provide unit tests that validate successful parsing and attribute extraction from sample syslog messages.
Checklist