This repository was archived by the owner on Sep 3, 2021. It is now read-only.
Remove spaces from generated scopes #258
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@ ## master #258 +/- ## ======================================= Coverage 94.47% 94.47% ======================================= Files 4 4 Lines 326 326 ======================================= Hits 308 308 Misses 18 18Continue to review full report at Codecov.
|
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Generated scopes contain a space in their name.
By standard scopes are sent to the backend as a space separated list.
See RFC 6749
This change removes the spaces from generated scopes and allows standard handling by existing libraries.
This breaking change as old scopes would not work anymore.
I'm not sure how others handled this I saw some solutions that separate scopes by colons but this would make it standard compatible.