Skip to content

Update 🛠_10_Time_series_fundamentals_and_Milestone_Project_3_BitPredi… #532

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update 🛠_10_Time_series_fundamentals_and_Milestone_Project_3_BitPredi… #532

wants to merge 1 commit into from

Conversation

@kahung33
Copy link

@kahung33 kahung33 commented Mar 31, 2023

…ct_💰📈_Exercise_Solutions.ipynb

According to the documentation of tensorflow, the ds should be generate in this way,

data = price[:-WINDOW_SIZE]
targets = price[WINDOW_SIZE:]

in the original code, both price are passed in,
it simply treat the 1st data point in price as the first label
@kahung33
Update 🛠_10_Time_series_fundamentals_and_Milestone_Project_3_BitPredi…
2ca0c07 
…ct_💰📈_Exercise_Solutions.ipynb According to the documentation of tensorflow, the ds should be generate in this way, data = price[:-WINDOW_SIZE] targets = price[WINDOW_SIZE:] in the original code, both price are passed in, it simply treat the 1st data point in price as the first label
@Bossenterprise
Copy link

Bossenterprise commented Apr 3, 2023

…ct_💰📈_Exercise_Solutions.ipynb

According to the documentation of tensorflow, the ds should be generate in this way,

data = price[:-WINDOW_SIZE]

targets = price[WINDOW_SIZE:]

in the original code, both price are passed in,

it simply treat the 1st data point in price as the first label
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@kahung33 @Bossenterprise