chore: rework list-projects response #665
Open
+120 −71
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR reworks the list-projects Atlas tool to return JSON formatted responses instead of table format, making it easier for LLMs to understand. It also refactors the integration tests to be independent of each other by implementing proper test isolation and cleanup mechanisms.
Key Changes
- Modified
list-projectstool output from table format to structured JSON - Implemented proper test isolation with individual project creation and centralized cleanup
- Removed shared argument object exports in favor of inline definitions
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
src/tools/atlas/read/listProjects.ts | Changed output format from table to JSON and inlined argument definitions |
src/tools/atlas/create/createProject.ts | Removed exported argument object in favor of inline definition |
tests/integration/tools/atlas/projects.test.ts | Reworked tests for independence with proper setup/cleanup and updated assertions for JSON format |
blva reviewed Oct 20, 2025
| }); | ||
| | ||
| it("should create a project", async () => { | ||
| const projName = `test-project-${new ObjectId().toString()}`; |
There was a problem hiding this comment.
nit: let's keep the expected project name prefix as we have a cleanup script running testProj-
blva reviewed Oct 20, 2025
| const formattedProjects = `Project Name | Project ID | Organization Name | Organization ID | Created At | ||
| ----------------| ----------------| ----------------| ----------------| ---------------- | ||
| ${rows}`; | ||
| const serializedProjects = JSON.stringify( |
There was a problem hiding this comment.
thanks for the change! I have a draft to update all other tools but will wait for this one to get merged first
blva reviewed Oct 20, 2025
| let projName: string; | ||
| let orgId: string; | ||
| beforeAll(async () => { | ||
| projName = `list-projects-test-${new ObjectId().toString()}`; |
There was a problem hiding this comment.
Suggested change
| projName = `list-projects-test-${new ObjectId().toString()}`; | |
| projName = `testProj-listProjects-${new ObjectId().toString()}`; |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Proposed changes
Reworks list-projects to return json instead of a table as LLMs have an easier time understanding json responses (our accuracy tests will occasionally fail because of that). Additionally, reworks the tests in projects.test.ts to be independent of one another.