Skip to content

Conversation

@mmoll
Copy link
Contributor

@mmoll mmoll commented Nov 28, 2017

No description provided.

@mmoll
Copy link
Contributor Author

mmoll commented Nov 28, 2017

let's see where this is going, per https://scrutinizer-ci.com/docs/tools/php/code-sniffer/

@codecov
Copy link

codecov bot commented Nov 28, 2017

Codecov Report

Merging #52 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@ Coverage Diff @@ ## master #52 +/- ## ========================================= Coverage 96.08% 96.08% Complexity 122 122 ========================================= Files 6 6 Lines 639 639 ========================================= Hits 614 614 Misses 25 25

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3c44dd9...75851ab. Read the comment docs.

@mmoll mmoll force-pushed the scrutinizer_phpcs branch from 4126ffc to c6ae56d Compare November 28, 2017 10:53
@xalopp
Copy link
Contributor

xalopp commented Nov 28, 2017

Maybe overriding the step with - phpcs-run --standard=phpcs.xml will work?

@mmoll mmoll force-pushed the scrutinizer_phpcs branch 5 times, most recently from 8c927a3 to c6e324c Compare November 28, 2017 21:57
@mmoll mmoll force-pushed the scrutinizer_phpcs branch from c6e324c to 75851ab Compare November 28, 2017 22:02
@mmoll
Copy link
Contributor Author

mmoll commented Nov 28, 2017

I wiped the whole phpcs defaults of Scrutinizer, now it seems good.

@xalopp
Copy link
Contributor

xalopp commented Nov 29, 2017

Sure? For me the log for the phpcs-run still looks the same. https://scrutinizer-ci.com/g/mayflower/mo4-coding-standard/inspections/84849830-413e-43b1-b9fd-13a175a7062e/log

Maye adding an error the phpcs.xml.dist will point out this file is used or not.

@mmoll
Copy link
Contributor Author

mmoll commented Nov 29, 2017

The "Patches" tab in the report is gone now and there are no generated "recommended" patches anymore.

@xalopp
Copy link
Contributor

xalopp commented Nov 29, 2017

Ok, now I get it 🤦‍♂️

@xalopp xalopp merged commit e3ec10a into mayflower:master Nov 29, 2017
@mmoll mmoll deleted the scrutinizer_phpcs branch April 29, 2018 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants