Skip to content

Conversation

@mmoll
Copy link
Contributor

@mmoll mmoll commented Nov 26, 2017

No description provided.

@codecov
Copy link

codecov bot commented Nov 26, 2017

Codecov Report

Merging #49 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@ Coverage Diff @@ ## master #49 +/- ## ========================================= Coverage 95.99% 95.99% Complexity 120 120 ========================================= Files 6 6 Lines 624 624 ========================================= Hits 599 599 Misses 25 25
Impacted Files Coverage Δ Complexity Δ
...iffs/Formatting/UnnecessaryNamespaceUsageSniff.php 100% <ø> (ø) 25 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 689ae3b...9f5b095. Read the comment docs.

@mmoll
Copy link
Contributor Author

mmoll commented Nov 26, 2017

I took the liberty to also add the webhook to this repo.


[![Build Status](https://travis-ci.org/mayflower/mo4-coding-standard.svg?branch=master)](https://travis-ci.org/mayflower/mo4-coding-standard)
[![Build Status](https://codecov.io/gh/mayflower/mo4-coding-standard/branch/master/graph/badge.svg)](https://codecov.io/gh/mayflower/mo4-coding-standard/branch/master/)
[![Scrutinizer Quality Level](https://scrutinizer-ci.com/g/mayflower/mo4-coding-standard/badges/quality-score.png?b=master)](https://scrutinizer-ci.com/g/mayflower/mo4-coding-standard)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I recommend to deactivated checking of the MO4/Tests/*/*.inc files. They are often broken on purpose 😸

@xalopp
Copy link
Contributor

xalopp commented Nov 27, 2017

NEIẞ catch:

UnnecessaryNamespaceUsageSniff::getNamespace() has wrong return type array instead of string.
Would be great if you fix that ;-)

@mmoll
Copy link
Contributor Author

mmoll commented Nov 27, 2017

done.

@xalopp xalopp merged commit ba1c9f3 into mayflower:master Nov 27, 2017
@mmoll mmoll deleted the scrutinizer branch November 27, 2017 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants