fix no multiline comments after declarations, fixes #96 #104
Conversation
xalopp changed the title 
Codecov Report
@@ Coverage Diff @@ ## master #104 +/- ## ========================================== + Coverage 98.47% 100% +1.52% Complexity 124 124 ========================================== Files 6 6 Lines 523 520 -3 ========================================== + Hits 515 520 +5 + Misses 8 0 -8
Continue to review full report at Codecov.
|
| $bla = 1; | ||
| /** @var int $bla */ | ||
| | ||
| return ($bla === $foo); /* yeah! */ |
There was a problem hiding this comment.
why /* yeah! */? it reads awkward if in the same changeset with /* invalid doc block y is null by default */.
As the later suggests any comment after declarations/code is unwanted.
P.S.
I see, only after declarations. Maybe state this in the faulty comment above?
There was a problem hiding this comment.
@calbrecht absolutely right. /* yeah! */ is misleading. I'll replace it with /* allowed single line comment */. That should settle this.
Thank for this insightful comment 👍
| comment */ | ||
| | ||
| private $y = null; /** invalid doc block y is null by default */ | ||
| private $q = null; /* invalid doc block y is null by default */ |
There was a problem hiding this comment.
/* invalid doc block after declaration */ -- please :), same above
There was a problem hiding this comment.
Correct. This should be /* valid single line comment */
Initially discussed in #104 (review) we want to have comments that actually tell the developer *why* the comment itself is invalid or misplaced. /cc @calbrecht
Initially discussed in #104 (review) we want to have comments that actually tell the developer *why* the comment itself is invalid or misplaced. /cc @calbrecht
Initially discussed in mayflower#104 (review) we want to have comments that actually tell the developer *why* the comment itself is invalid or misplaced. /cc @calbrecht (cherry picked from commit 4806232)
Initially discussed in #104 (review) we want to have comments that actually tell the developer *why* the comment itself is invalid or misplaced. /cc @calbrecht (cherry picked from commit 4806232)
3 participants
No description provided.