fix: improve perf of _maybe_filter_foreign_keys method #667
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Member
| thank you! would you mind checking the mypy errors? |
mistercrunch force-pushed the optimize__maybe_filter_foreign_keys branch from 0401d05 to 547f5ba Compare Contributor Author
| Oh, didn't notice |
Contributor Author
| Nice, will try to see if this fixed our CI issues when the next version is out, presumable 4.1.2- skipping over 4.1.1 - could probably test now but would have to mess around with referencing the |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Optimizing a method to try and address the issue described here -> #665
A bit of a shot in the dark, but this optimization should help significantly. Unclear if it will address the memory-related issue, would have to dig deeper in the call stack to understand what it does.
I have to admit I don't actually understand what the code does, so this optimization is purely theoretical.