Skip to content

Small improvements #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 6 commits into from
Closed

Small improvements #47

wants to merge 6 commits into from

Conversation

@debnet
Copy link

@debnet debnet commented Jan 4, 2016

  • Fixing displayed URL by using pattern instead of name_parent regex (for namespaced URLs mainly)
  • Distinction between custom API views and RESTFul APIs generated through models and routers
  • Adding possibility to use app_name in URL patterns for API organisation
  • Adding an URL to filter APIs by app_name or name_parent
Maxence and others added 3 commits December 22, 2015 17:24
(Not tested yet)
d036de0 
Added the possibility to filter by application name in the url + modifed the name_parent's value of the ApiEndpoint
Preparing merge with upstream/master
c6401a9
Add app_name in urls + tests
deb9446
@debnet
Copy link
Author

debnet commented Jan 4, 2016

Tests added for the new features
@manosim
Copy link
Owner

manosim commented Jan 4, 2016

A few small bits:

  • When in /docs/app_name/ can we hide the "Jump to" dropdown from the navbar?
  • Link each app name(heading) to that url? (Maybe on hover show an # that links to that url - or something similar)
  • What if there is no defined app_name for a namespace? Would be great if we can use something like the parent so that it works with all the namespaces.

Other than that it looks great! Can't wait to merge it ✨
@debnet
Copy link
Author

debnet commented Jan 5, 2016

OK, we are working on it. ;)
Maxence added 3 commits January 5, 2016 15:25
- Show the "Jump to" dropdown only if there is more than 1 value
e2744a0 
- Add link to the ''/docs/[filter_name]'' for each group.grouper (name_parent) - Parameter in the 'docs/filter_name' now works with app_name or namespace - WARNING: Modify the urlpatterns for django version >= 1.9 (see deprecated use of app_name : https://docs.djangoproject.com/en/1.9/ref/urls/#include)
Add '-' to the url patten
b774268
Use the endpoint's namespace into the group url
e866a41
@debnet
Copy link
Author

debnet commented Jan 5, 2016

Done. Just to do some styling on title hyperlinks, we leave it to you. ;)

Exemple:

h1 { > a { color:#2C3E50 ; &:hover { text-decoration: none; } } }
@manosim manosim mentioned this pull request Jan 5, 2016
Closed
@manosim
Copy link
Owner

manosim commented Jan 5, 2016

Thank you @debnet! Moving this one to #48. 🎉
@manosim manosim closed this Jan 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement work in progress

2 participants

@debnet @manosim