Add ReCaptcha coverage for Contact GraphQL (SwiftOtter's SOP-348) #335
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| @magento run all tests |
lbajsarowicz changed the title | @ihor-sviziev Can you take a look? |
| Tagging @nathanjosiah, maybe he'll be able to move this PR forward |
| public function getConfigFor(EndpointInterface $endpoint): ?ValidationConfigInterface | ||
| { | ||
| if ($endpoint->getServiceMethod() === 'resolve' | ||
| && $endpoint->getServiceClass() === ContactUs::class) { |
There was a problem hiding this comment.
I see in other places we have a || here. are you sure it should be &&?
Example: https://github.com/magento/security-package/blob/develop/ReCaptchaCustomer/Model/WebapiConfigProvider.php#L65-L69
There was a problem hiding this comment.
@ihor-sviziev After the research, I found out that \Magento\ReCaptchaSendFriend\Model\WebapiConfigProvider::getConfigFor is the most in-line with Contact form, that's why it's && not ||
ReCaptchaContact/etc/di.xml Outdated
| <type name="Magento\ReCaptchaWebapiApi\Model\CompositeWebapiValidationConfigProvider"> | ||
| <arguments> | ||
| <argument name="providers" xsi:type="array"> | ||
| <item name="contactUs" xsi:type="object">Magento\ReCaptchaContact\Model\WebapiConfigProvider</item> |
There was a problem hiding this comment.
Why not "Contact", as a module name?
Suggested change
| <item name="contactUs" xsi:type="object">Magento\ReCaptchaContact\Model\WebapiConfigProvider</item> | |
| <item name="contact" xsi:type="object">Magento\ReCaptchaContact\Model\WebapiConfigProvider</item> |
There was a problem hiding this comment.
Introduced change in the codebase.
m2-community-project bot added Progress: review Progress: ready for review and removed Progress: ready for review Progress: review labels 
ihor-sviziev approved these changes Aug 4, 2024
m2-community-project bot added Progress: approved and removed Progress: ready for review labels Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Description (*)
According to the official documentation, Magento 2.4.7 comes without ReCaptcha coverage for Contact form GraphQL endpoint.
This Pull Requests fills this incomprehensible gap.
Fixed Issues (if relevant)
Manual testing scenarios (*)
GraphQL call to verify:
Questions or comments
Contribution checklist (*)