Skip to content

Updated endroid/qr-code to 4.3.5 #314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 1, 2021
Merged

Updated endroid/qr-code to 4.3.5 #314

merged 2 commits into from
Nov 1, 2021

Conversation

@anzin
Copy link
Contributor

@anzin anzin commented Oct 15, 2021

Description (*)

Updated endroid/qr-code dependency to the latest version (4.3.5).

Fixed Issues (if relevant)

  1. [2.4.x] Update endroid/qr-code dependency to the latest version magento2#34101

Contribution checklist (*)

  • Author has signed the Adobe CLA
  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)
@andrewbess
Copy link
Contributor

@magento run all tests with env PHP 8.0
@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.
@andrewbess
Copy link
Contributor

@magento run all tests
@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.
@xmav
Copy link
Contributor

xmav commented Oct 15, 2021

@anzin Could you please do smoke manual test to verify changed code ?
@anzin anzin force-pushed the improvements/update-endroid-qr-code-to-latest-version branch from 996443f to 57473d3 Compare October 18, 2021 09:47
@anzin
Copy link
Contributor Author

anzin commented Oct 18, 2021

@magento run all tests with env PHP 8.0
@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.
@anzin
Copy link
Contributor Author

anzin commented Oct 18, 2021

@magento run all tests
@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.
@andrewbess
Copy link
Contributor

@magento run Functional Tests B2B, Functional Tests EE, WebAPI Tests with env PHP 8.0
@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.
@andrewbess
Copy link
Contributor

@magento run Functional Tests EE
@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.
@xmav
Copy link
Contributor

xmav commented Oct 26, 2021

test build with new library dependency is in progress
@xmav
Copy link
Contributor

xmav commented Oct 26, 2021

Hi @anzin!
Please fix static tests failure:

1) Magento\Test\Php\LiveCodeTest::testCodeMess PHP Code Mess has found error(s): /var/www/html/app/code/Magento/TwoFactorAuth/Test/Unit/Model/Provider/Engine/GoogleTest.php:25	The class GoogleTest has a coupling between objects value of 13. Consider to reduce the number of dependencies under 13.

All other tests passed on env with new library
@anzin
Copy link
Contributor Author

anzin commented Oct 26, 2021

@magento run Static Tests
@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.
@anzin anzin changed the base branch from platform-health to develop October 29, 2021 07:03
@xmav
Copy link
Contributor

xmav commented Nov 1, 2021

@magento import pr to magento-commerce
@xmav
Copy link
Contributor

xmav commented Nov 1, 2021

@magento import pr to magento-commerce/security-package
@m2-github-services
Copy link
Collaborator

@xmav the Pull Request is successfully imported.
@magento-devops-reposync-svc magento-devops-reposync-svc merged commit 4a8b76d into magento:develop Nov 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Partner: Atwix partners-contribution Progress: done

6 participants

@anzin @andrewbess @xmav @m2-github-services @magento-engcom-team @magento-devops-reposync-svc