Skip to content

Conversation

@comdiler
Copy link

@comdiler comdiler commented Jan 12, 2021

Description (*)

Email notification for 2FA configuration has a wrong link, which leads to 404 page

Fixed Issues (if relevant)

  1. Email notification for 2FA configuration has a wrong link, which leads to 404 page #285: Email notification for 2FA configuration has a wrong link, which leads to 404 page

Manual testing scenarios (*)

  1. Login to admin panel
  2. Go to System - Permissions - All Users
  3. Add a new admin user
  4. Send a /rest/default/V1/integration/admin/token POST request with username and password from step 3
    You will get a response about email notification has been sent
    image
  5. Check received email and click the link
    image
    image
  6. Link should lead to the 2FA settings page

Contribution checklist (*)

  • Author has signed the Adobe CLA
  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)
@magento-engcom-team
Copy link

@nathanjosiah the branch with code successfully imported intomagento-commerce/security-package repository. Branch name: imported-magento-security-package-286.

@nathanjosiah
Copy link
Contributor

I had to change the namespace in the WebApiUserNotifier as well. While I was in there I also added a few tests for automated coverage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

5 participants