Skip to content

Conversation

@donatj
Copy link

@donatj donatj commented Dec 29, 2020

Description (*)

Upgrades donatj/phpuseragentparser major version. The 0.x branch will soon be unmaintained.

I maintain donatj/phpuseragentparser and can state that no changes are necessary as there is a backwards compatibility layer.

Contribution checklist (*)

  • Author has signed the Adobe CLA
  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)
@donatj
Copy link
Author

donatj commented Dec 29, 2020

I signed the CLA despite it saying I have not.

@nathanjosiah nathanjosiah added the Component: 2FA Issues and Pull Requests related to Two Factor Authentication should be marked with this label label Jan 5, 2021
@nathanjosiah
Copy link
Contributor

@nathanjosiah
Copy link
Contributor

donatj/phpuseragentparser is no longer used by security-package and will be removed in scope of internal ticket https://jira.corp.magento.com/browse/AC-7 and PR #315

@donatj
Copy link
Author

donatj commented Oct 15, 2021

Sad day

@donatj donatj deleted the patch-1 branch March 15, 2022 03:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Component: 2FA Issues and Pull Requests related to Two Factor Authentication should be marked with this label Progress: ready for review

2 participants