Skip to content

Fix broken dependency test. #278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Fix broken dependency test. #278

wants to merge 1 commit into from

Conversation

@swnsma
Copy link

@swnsma swnsma commented Oct 8, 2020

During fixing of Dependency tests there was discovered that one of the Security Package modules has wrong dependencies.

Related PR:
magento/magento2#30331
@swnsma swnsma mentioned this pull request Oct 8, 2020
Closed
1 task
@mmansoor-magento mmansoor-magento changed the base branch from 1.0-develop to develop November 17, 2020 04:12
@nathanjosiah
Copy link
Contributor

@swnsma Can you help me understand why adding a suggest to composer fixes any dependency issues? AFAIK this doesn't change the dependency tree at all but rather just outputs a message when composer installs the package
@nathanjosiah
Copy link
Contributor

Closing due to inactivity
@swnsma
Copy link
Author

swnsma commented Sep 11, 2021

Hi @nathanjosiah,
Using of 'suggest' mark dependencies which mentioned in the module and does not required for it's work: dependency in plugins, tests etc.
In this extension Magento_Backend is used in tests.
@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.
1 similar comment
@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Partner: Vaimo partners-contribution

4 participants

@swnsma @nathanjosiah @ihor-sviziev @magento-engcom-team