Skip to content

magento/security-package#203: Recaptch badge with German language is not shown fully on Product Review tab #254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 27, 2021
Merged

magento/security-package#203: Recaptch badge with German language is not shown fully on Product Review tab #254

merged 2 commits into from
May 27, 2021

Conversation

engcom-Foxtrot
Copy link
Contributor

Description (*)

Fixed Issues (if relevant)

  1. Fixes reCAPTCHA badge with several language is not shown fully  #203: Recaptch badge with German language is not shown fully on Product Review tab

Manual testing scenarios (*)

  1. See reCAPTCHA badge with several language is not shown fully  #203: Recaptch badge with German language is not shown fully on Product Review tab

Questions or comments

Contribution checklist (*)

  • Author has signed the Adobe CLA
  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)
@engcom-Foxtrot engcom-Foxtrot requested a review from naydav July 13, 2020 13:02
@engcom-Foxtrot engcom-Foxtrot changed the base branch from 1.0-develop to 1.0.0-develop July 13, 2020 13:02
@engcom-Foxtrot
Copy link
Contributor Author

@magento run all tests
@engcom-Foxtrot engcom-Foxtrot force-pushed the magento/security-package#203 branch from 3263852 to ce43a44 Compare July 13, 2020 13:09
@engcom-Foxtrot
Copy link
Contributor Author

@magento run all tests
@engcom-Foxtrot engcom-Foxtrot added the Component: Google reCAPTCHA Issues and Pull Requests related to reCAPTCHA should be marked with this label label Jul 13, 2020
@engcom-Delta engcom-Delta self-assigned this Jul 13, 2020
@engcom-Foxtrot
Copy link
Contributor Author

@magento run all tests
@engcom-Delta
Copy link

✔️ QA passed
Recaptcha badges are shown propely

  • reCAPTCHA v2 ("I am not a robot")
    #254PRV2NotRobot

  • reCAPTCHA v2/V3 Invisible
    #254PRV2_V3inv
@naydav naydav added the 2.4-develop: exclude 2.4-develop: exclude label Aug 11, 2020
@nathanjosiah nathanjosiah requested review from nathanjosiah and removed request for naydav May 27, 2021 20:12
@nathanjosiah nathanjosiah merged commit 33221d4 into 1.0.0-develop May 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2.4-develop: exclude 2.4-develop: exclude Component: Google reCAPTCHA Issues and Pull Requests related to reCAPTCHA should be marked with this label Progress: done

4 participants

@engcom-Foxtrot @engcom-Delta @nathanjosiah @naydav