Skip to content

[MFTF] [1.0-develop] MQE-2194: fix mftf tests static check failures #246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 17, 2020
Merged

[MFTF] [1.0-develop] MQE-2194: fix mftf tests static check failures #246

merged 1 commit into from
Jun 17, 2020

Conversation

jilu1
Copy link
Contributor

@jilu1 jilu1 commented Jun 15, 2020

Description (*)

Fixed Issues (if relevant)

  1. magento/magento2#<issue_number>: Issue title

Manual testing scenarios (*)

  1. ...
  2. ...

Questions or comments

Contribution checklist (*)

  • Author has signed the Adobe CLA
  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)
@jilu1 jilu1 changed the title MQE-2194: fix mftf tests static check failures [MFTF] [1.0-develop] MQE-2194: fix mftf tests static check failures Jun 15, 2020
@jilu1 jilu1 requested a review from ishakhsuvarov June 16, 2020 16:33
@jilu1
Copy link
Contributor Author

jilu1 commented Jun 16, 2020

This PR is critical for MFTF team to enable static checks on builds. @ishakhsuvarov Can you please review and process it as a priority?
@nathanjosiah
Copy link
Contributor

@magento run all tests
@nathanjosiah nathanjosiah merged commit 08267b0 into magento:1.0-develop Jun 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@jilu1 @nathanjosiah