Skip to content

Conversation

lano-vargas
Copy link

Adding Group by option_id select statement resolves to one row per option, If later date provided Store View id this should still be fine or can be redundant.

Description (*)

Add group by to return on line per option id

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes GraphQl Get Product Filter By Category display incorrect label  #29635

Manual testing scenarios (*)

  1. ... use graphql tool to fetch data:
query getProductFiltersByCategory($categoryIdFilter: FilterEqualTypeInput!) { products(filter: { category_id: $categoryIdFilter }) { aggregations { label count attribute_code options { label value } } } } 

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)
Adding Group by `option_id` select statement resolves to one row per option, If later date provided Store View id this should still be fine or can be redundant.
@m2-assistant
Copy link

m2-assistant bot commented Aug 18, 2020

Hi @lano-vargas. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@rogyar
Copy link
Contributor

rogyar commented Aug 30, 2020

Hi @lano-vargas. Thank you for your collaboration. Could you cover, please, your fix with an API-functional test? According to the definition of done all changes should be covered by autotests.

Thank you!

@m2-community-project m2-community-project bot added the Priority: P2 A defect with this priority could have functionality issues which are not to expectations. label Mar 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests Award: bug fix Component: CatalogGraphQl Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: pending review Project: GraphQL Release Line: 2.4

6 participants