Skip to content

Added DI StockItemRepository + validation method: validateStockItem #26722

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: 2.4-develop
Choose a base branch
from
Open

Added DI StockItemRepository + validation method: validateStockItem #26722

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 35 additions & 3 deletions app/code/Magento/BundleGraphQl/Model/Resolver/Links/Collection.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
use Magento\Bundle\Model\ResourceModel\Selection\CollectionFactory;
use Magento\Bundle\Model\ResourceModel\Selection\Collection as LinkCollection;
use Magento\Framework\GraphQl\Query\EnumLookup;
use Magento\CatalogInventory\Model\Stock\StockItemRepository;

/**
* Collection to fetch link data at resolution time.
Expand Down Expand Up @@ -43,13 +44,25 @@ class Collection
private $links = [];

/**
* @var StockItemRepository
*/
protected $stockItemRepository;

/**
* Collection constructor.
*
* @param CollectionFactory $linkCollectionFactory
* @param EnumLookup $enumLookup
* @param StockItemRepository $stockItemRepository
*/
public function __construct(CollectionFactory $linkCollectionFactory, EnumLookup $enumLookup)
{
public function __construct(
CollectionFactory $linkCollectionFactory,
EnumLookup $enumLookup,
StockItemRepository $stockItemRepository
) {
$this->linkCollectionFactory = $linkCollectionFactory;
$this->enumLookup = $enumLookup;
$this->stockItemRepository = $stockItemRepository;
}

/**
Expand Down Expand Up @@ -83,7 +96,26 @@ public function getLinksForOptionId(int $optionId) : array
return [];
}

return $linksList[$optionId];
return $this->validateStockItem($linksList[$optionId]);
}

/**
* Validate is Product in Stock
*
* @param $items
* @return array
*/
private function validateStockItem($items): array
{
foreach ($items as $key => $item) {
$productStock = $this->stockItemRepository->get($item['product_id']);

if (!$productStock->getIsInStock()) {
unset($items[$key]);
}
}

return $items;
}

/**
Expand Down