Skip to content

Conversation

Rrego6
Copy link
Contributor

@Rrego6 Rrego6 commented Jan 27, 2021

Description (*)

This PR contains a collection of changes and fixes as part of the delivery for: https://jira.corp.magento.com/browse/MC-38148

  • Adds a new section to HTML SVC report showing the level of changes made to packages in JSON and table format. A Copy to clipboard button is added for the json content.
  • Resolves PackageName for the changed file by recursing up the directory to find the relevant composer.json
  • Fixes src/Console/Command/CompareSourceCommand.php to return a code instead of exiting
  • All Operations (stored versioning changes) will now display the full filepath in the location section of the HTML tables
  • Utilizes the mapping array property in the Registry class to store information about the filepath.
  • Adds automated testing for testing these changes to the HTML report
    • Copies examples for testing multiple changes together into the tests/Unit/Console/Command/CompareSourceCommandTest/_files/all/ directory

Fixed Issues (if relevant)

Reviews have been performed within these tickets:

  1. https://jira.corp.magento.com/browse/MC-38348
  2. https://jira.corp.magento.com/browse/MC-38349

Manual testing scenarios (*)

  1. Run 2.3-develop vs 2.4-develop using both mainline and this branch. Compared changes and make sure they are the same.
  2. Ensure package Level Changes displays all package names and level of changes of BIC which causes SVC build fail (core build and MFTF)
  3. User should be able to copy content of Package Level Changes and paste to PR description
  4. Target/Location column should show file path of the BIC
  5. Ensure all unit tests (included new tests) are green

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)
Rrego6 added 20 commits January 8, 2021 12:44
- Display full filename for xml changes - Displa package level changes in html report - Fixed tests - Added table for package level changes - Added copy-paste button
- Code refactoring - Add helper methods to XmlRegistry
- Fixed mistakes in PackageNameResolver
- Codefixes for DbSchemaWhitelistAnalyzer
- Removed redundant layout analyzer code
- Fixed handling of displaying packages within allowed change level
- Fixed namespace casing
- Fixes for Layout and DatabaseWhitelist Analyzer
- Spelling fix for docblock
- Simplify level check for packages
- Fix conditional logic
- WIP on MC-38349 - Created code for parsing contents of html - Added test cases for html
- Completed expanding db_schema cases
- Completed expanding di_xml and layout cases - Began expanding MFTF
- use more generic pathname in tests
- Fixed issues within tests - Removed nonapi checks - Changed mftf example to patch change
@Rrego6
Copy link
Contributor Author

Rrego6 commented Jan 27, 2021

Looks like the CI/build uses php 8.0? This should be using the earliest php version in composer.json (7.2)

I have added multiple people to the review, but I think one reviewer from the admin section should be sufficient.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

1 participant