MC-22691: Investigate and Fix redundant files by SVC #20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
- Reverted seperate handling of .json files. - Added functionality of DbScehmaScanner to view the corresponding db_schema.xml or db_schema_whitelist.json if one is changed.
fascinosum requested changes Dec 9, 2019
| return; | ||
| } | ||
| if ($this->isXml($file)) { | ||
| if ($this->isXml($file) && !$this->isXmlAlreadyScanned($file)) { |
There was a problem hiding this comment.
What is the case of this workaround here?
There was a problem hiding this comment.
Its necessary for the case where db_schema.xml and db_schema_whitelist.json both have changes.
Without this check. db_schema.xml and db_schema_whitelist.json will both be scanned twice.
| Hey @Rrego6 I fixed the issue with introduction a separate |
| I will close as this fix isn't necessary anymore. |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
db_schema_whitelist.json if one is changed.
Description (*)
Fixed Issues (if relevant)
Manual testing scenarios (*)
...
...
Questions or comments
Contribution checklist (*)