Fix smart HTTP transport protocol handling #952
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This fixes the smart HTTP transport implementation receive pack service to send requests to `/git-receive-pack` instead of `/info/Refs?service=git-upload-pack`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This fixes the smart HTTP transport implementation receive pack service to send requests to
/git-receive-packinstead of/info/Refs?service=git-upload-pack.This issue seems to stem from a bad copy-paste, because this was the only difference when comparing the traces of a git push done with
git2gowith the regulargitclient.In case of a HTTPS push, it would before result in a
HTTP 405 Method Not Allowed(at least on the Gitea instance I was testing it on), and it now works.