Skip to content

Set BasicAuth in http.go only if username and password are not empty (#914) #920

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: release-0.28
Choose a base branch
from
Open

Set BasicAuth in http.go only if username and password are not empty (#914) #920

wants to merge 1 commit into from

Conversation

github-actions[bot]
Copy link

This prevents error "read/write on closed pipe".

Go's http.client::send() always closes req.Body, so if the first request attempt
is unsuccessful, any subsequent requests after calling the CredentialsCallback
will attempt to read/write on a closed pipe.

(cherry picked from commit 9db5de1)
@clns @lhchavez
Set BasicAuth in http.go only if username and password are not empty (#…
38313ce 
…914) This prevents error "read/write on closed pipe". Go's http.client::send() always closes req.Body, so if the first request attempt is unsuccessful, any subsequent requests after calling the `CredentialsCallback` will attempt to read/write on a closed pipe. (cherry picked from commit 9db5de1)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

1 participant

@clns