Add a "go to implementation" action for scopes #462
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| Finally! It really frustating to get many implementations popup and should choose the right one or straight to docblock not the real implementation |
N1ebieski changed the title 
damms005 reviewed Oct 9, 2025
Contributor
damms005 left a comment
damms005 left a comment There was a problem hiding this comment.
Awesome one as usuals, @N1ebieski. Just minor touches for when working in containerized environments.
php-templates/models.php Outdated
| ->filter(fn(\ReflectionMethod $method) =>!$method->isStatic() && ($method->getAttributes(\Illuminate\Database\Eloquent\Attributes\Scope::class) || ($method->isPublic() && str_starts_with($method->name, 'scope')))) | ||
| ->map(fn(\ReflectionMethod $method) => [ | ||
| "name" => str($method->name)->replace('scope', '')->lcfirst()->toString(), | ||
| "uri" => $method->getFileName(), |
Contributor
There was a problem hiding this comment.
Suggested change
| "uri" => $method->getFileName(), | |
| "uri" => $method->getFileName(), | |
| "relative_path" => str($method->getFileName())->after(base_path())->toString(), |
In Docker-based environments, $method->getFileName() is the container path, which fails when clicked on hover. Adding relative_path will make it easy to resolve the path to the file in the host
Contributor Author
There was a problem hiding this comment.
You're right. I've replaced uri $method->getFileName() with LaravelVsCode::relativePath. Could you check if the problem still occurs?
damms005 reviewed Oct 9, 2025
Contributor Author
| @damms005 Thanks for your review! |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Currently, if the user uses Intelephense or other PHP code intelligence for Visual Studio Code, ctrl+click on the scope method name takes the user to the method docblocks definition in _model_helpers.php stub file:
It's OK, but it's inconvenient for Laravel's scopes methods. Especially if we have hundreds scopes and must fast modify one of them.
This PR adds "Go to implementation" action which takes the user directly to the scope implementation:
Scopes in traits are supported as well.
Would be even better if I could use VSCode DefinitionProvider for this purpose, but Intelephense also registers own Provider and ctrl+click on the method name is always handled first by Intelephense. If someone knows how to deal with it, please let me know.
Important: Depends on laravel/vs-code-php-parser-cli#22 and highly recommended is also laravel/vs-code-php-parser-cli#23