[12.x] Improve Collection docblock types #58176
Open
+95 −15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
jnoordsij commented Dec 20, 2025
| }, preserveKeys: true)); | ||
| | ||
| assertType('Illuminate\Support\Collection<(int|string), User>', $collection->keyBy('name')); | ||
| assertType('Illuminate\Support\Collection<string, User>', $collection->keyBy(function ($user, $int) { |
Contributor Author
There was a problem hiding this comment.
FWIW apparently the type inheritance got 'overspecific' here, actualy inferring the very specific return type 'foo' where it previously didn't. Although this is semantically all correct, I'm not sure why this happens only now and here.
jnoordsij force-pushed the improve-collection-docblock-types branch from 33f58e6 to 52ec385 Compare Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This PR is a follow-up to:
Collection(param) docblocks #58170 as although this fixes inheritance, it also 'exposed' an incorrect typing on thecountBymethod added in [12.x] ImprovecountBydocblock inCollectionto allow for enum callback #56856 lacking a set of parenthesescountBydocblock inCollectionto allow for enum callback #56856 in adding a more fine-grained return type for thecountBymethod, which is subsequently also applied to thegroupByandkeyBymethods.It also adds some tests to the
typesto illustrate the behavior is currently incorrect and fixed by subsequent commits.