Skip to content

[12.x] Add dark mode support for email templates and extract media queries #57995

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
MrPunyapal wants to merge 1 commit into
base: 12.x
Choose a base branch
from
Open

[12.x] Add dark mode support for email templates and extract media queries #57995

MrPunyapal wants to merge 1 commit into from
+296 −20

Conversation

@MrPunyapal
Copy link
Contributor

@MrPunyapal MrPunyapal commented Dec 2, 2025 •
edited
Loading

Better alternative to #57989

image
@MrPunyapal MrPunyapal marked this pull request as ready for review December 2, 2025 07:14
@MrPunyapal
Copy link
Contributor Author

MrPunyapal commented Dec 2, 2025 •
edited
Loading

Added merged PR for deprecation warning tijsverkoyen/CssToInlineStyles#257

-- update
It's released
@MrPunyapal MrPunyapal mentioned this pull request Dec 2, 2025
Closed
@WendellAdriel
Copy link
Contributor

WendellAdriel commented Dec 2, 2025

Very nice @MrPunyapal!
I like this approach better than the #57989
@shaedrich
Copy link
Contributor

shaedrich commented Dec 3, 2025 •
edited
Loading

Would you mind adding comparison images to your PR description (however, I assume, this looks identical to #57989)? That would be quite helpful :)
@MrPunyapal
Copy link
Contributor Author

MrPunyapal commented Dec 3, 2025

@shaedrich light mode vs dark mode?
@shaedrich
Copy link
Contributor

shaedrich commented Dec 3, 2025

@MrPunyapal Yeah, that's what I meant.
@taylorotwell taylorotwell marked this pull request as draft December 8, 2025 22:27
@MrPunyapal MrPunyapal force-pushed the feat/dark-mode-support-for-mail-2 branch from 9322cb9 to dd055b0 Compare December 18, 2025 05:38
@MrPunyapal MrPunyapal marked this pull request as ready for review December 18, 2025 05:42
@MrPunyapal
Copy link
Contributor Author

MrPunyapal commented Dec 18, 2025

@taylorotwell PHP depreciation error is gone.
As it's released: https://github.com/tijsverkoyen/CssToInlineStyles/releases/tag/v2.4.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants

@MrPunyapal @WendellAdriel @shaedrich