Skip to content

Conversation

@eliecharra
Copy link
Member

For #38

@eliecharra
Copy link
Member Author

eliecharra commented Nov 29, 2018

⚠️ With opcache.validate_timestamps, a fpm restart is required for deployment to be effective.

This introduce BC break in this image @jcrombez maybe we should update projects deployed with capistrano under bind mounted volumes in this image to restart fpm to clear opcache cache.

Merge when our deploy strategy were updated only imho

EDIT : parameter removed in 8739e43

@jcrombez
Copy link
Contributor

I don't see this as a BC break really, the normal way of deploying docker container is to restart them so the need to restart fpm shouldn't really be a problem.

@jcrombez jcrombez merged commit 9a31ee6 into master Nov 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

4 participants