only accept input number, "+", "-", backspace, space, enter, tab #62
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@ ## master #62 +/- ## ========================================== + Coverage 97.95% 98.03% +0.08% ========================================== Files 1 1 Lines 49 51 +2 Branches 20 21 +1 ========================================== + Hits 48 50 +2 Partials 1 1
Continue to review full report at Codecov.
|
| Hi @cyrax1800, Thanks for the PR however as for user experience, we shouldn't interfere with user input and "correct" the input after the user has finished (on blur) IMHO. Please consider to file an issue first before proposing implementation changes as in contribution guidelines |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
To make a better User Experience