Skip to content

Conversation

@daycry
Copy link

@daycry daycry commented Apr 7, 2016

This file is OK

This file is OK
@kenjis
Copy link
Owner

kenjis commented Apr 8, 2016

Why don't you just add paths for modules in config?
Do you really need to the functionality which adds module path dynamically?

@kenjis
Copy link
Owner

kenjis commented Apr 8, 2016

You can set module path dynamically when loading this Twig library.
See https://github.com/kenjis/codeigniter-ss-twig#loading-twig-library

I don't want to couple this libary with HMVC. Because it is a simple library.

@kenjis kenjis closed this Apr 8, 2016
@daycry
Copy link
Author

daycry commented Apr 8, 2016

I think that is better, because you dont need create any config file.
On 8 Apr 2016 02:02, "kenjis" notifications@github.com wrote:

Why don't you just add paths for modules in config?
Do you really need to the functionality which adds module path dynamically?


You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
#13 (comment)

@kenjis
Copy link
Owner

kenjis commented Apr 9, 2016

@daycry I don't use HMVC as possible. Because it provides more complexity to CodeIgniter.
The official CodeIgniter will never support HMVC.
So I don't want to couple my Twig library tightly with HMVC.

At least, you need to write test code for your code.
The current code coverage is 98.51%, but your PR has no test code, and the coverage is 81.61%.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants