Switch to Go Modules and cleanup Dockerfile #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
bart-degreed force-pushed the netcore31 branch 3 times, most recently from 7e0a07f to 7de905f Compare 
| Superseded by #8. Thanks for your help! |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Recently Go switched to using Go modules for their dependency management. This updates the project to make use of those.
It also introduces the builder pattern for the Docker files to keep a minimal image. It first builds the load test Go binary and Vegeta (dependency) and later copies that into the image that actually runs the test. This way we have a clean image and it also runs a more suitable OS, instead of the OS required for building Go binaries.