Skip to content

JADNC: Required Input validation disabled for partial patching / relationships #781

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 27 commits into from
Jun 16, 2020
Merged

JADNC: Required Input validation disabled for partial patching / relationships #781

Changes from 1 commit
Commits
Show all changes
27 commits
Select commit Hold shift + click to select a range
c4c27aa
disable validator if partial patch
Jun 9, 2020
ead6930
Create required validator that can be diabled to allow for partial pa…
Jun 9, 2020
a4c688d
formatting
Jun 9, 2020
7d3f57a
Remove unneeded reference.
Jun 9, 2020
11bd7d9
package reference
Jun 9, 2020
c02ef34
Requested changes:
Jun 10, 2020
9e40b88
Add version wildcard
Jun 10, 2020
a0de349
expect possible null in HttpContextExtension method
Jun 10, 2020
86989e6
change parameter order and naming for consistency
Jun 10, 2020
50ae2e4
Requested changes
Jun 10, 2020
102e636
Remove unneeded null check.
Jun 10, 2020
3917539
add null checks
Jun 10, 2020
cfbc9e3
generate fake name for author
Jun 10, 2020
0bcebe3
Moved logic to RequestDeserializer, overriding methods in BaseDocumen…
Jun 10, 2020
6a682ed
remove references
Jun 10, 2020
c2f2a69
formatting
Jun 10, 2020
81e764e
back to var
Jun 10, 2020
126a1a8
Requested changes:
Jun 11, 2020
a1596d5
formatting
Jun 11, 2020
d82f193
formatting
Jun 11, 2020
6882b19
change access modifiers
Jun 11, 2020
96cbd84
Requested changes:
Jun 15, 2020
945691d
refactor
Jun 15, 2020
4496d72
remoev comma.
Jun 15, 2020
4bc23b7
Merge remote-tracking branch 'upstream/master' into input_validation_…
Jun 16, 2020
7eeb6c5
Cleanup
Jun 16, 2020
44a9d92
removed unneeded code
Jun 16, 2020
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove unneeded null check.
  • Loading branch information
Sarah McQueary committed Jun 10, 2020
commit 102e636c0d010367f8de8120c02caf55d3a8480b
2 changes: 1 addition & 1 deletion src/JsonApiDotNetCore/Serialization/Common/BaseDocumentParser.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,7 @@ protected IIdentifiable SetRelationships(IIdentifiable entity, Dictionary<string
var entityProperties = entity.GetType().GetProperties();
foreach (var attr in relationshipAttributes)
{
_httpContextAccessor?.HttpContext?.DisableValidator( "Relation", attr.PropertyInfo.Name);
_httpContextAccessor.HttpContext.DisableValidator( "Relation", attr.PropertyInfo.Name);

if (!relationshipsValues.TryGetValue(attr.PublicRelationshipName, out RelationshipEntry relationshipData) || !relationshipData.IsPopulated)
continue;
Expand Down