DefaultEntityRepository cleanup #518
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
…ew one without id parameter
wisepotato suggested changes Jun 12, 2019
wisepotato suggested changes Jun 12, 2019
wisepotato suggested changes Jun 17, 2019
wisepotato approved these changes Jun 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This PR fixes of several issues and a bunch of refactoring.
DefaultEntityRepositorytries to attach entities to theDbContextthat are already attached. This may happened when entities involved to a update or create request were already loaded in the dbcontext elsewhere (eg Resource Hooks). Closes Refactor AttachRelationships: prevent reattachment, support implicit remove #502. This fix is needed for the tests to pass in Hooks #478IInverseRelationshipservice is introduced (actually it was cherry picked from the Resource Hooks PR). See Refactor AttachRelationships: prevent reattachment, support implicit remove #502.AttachRelationshipsmethod and those associated to it such thatIJsonApiContextfor the values of updated relationships and attributes. Still uses it to identify which attributes/relationships to update. See DefaultEntityRepository: inconsistent data handling #519UpdateAsync(TId id, TEnity entity)as obsolete, added a new one:UpdateAsync(TEnity updatedEntity)which actually uses the updated entity in the repository layer, as opposed to it just being passed along and being left untouched in the previous implementation. See DefaultEntityRepository: inconsistent data handling #519IJsonApiContexRelationshipsToUpdate,HasOnePointers,HasManyPointers. The first one has become an alias for the latter two, and the latter two are no longer populated with the actual relationship values as these are not used anymore in the repository layer. This is related to [draft] Feat/serializer context decoupling #512.