Skip to content

Conversation

verdie-g
Copy link
Contributor

Closes #1298

I was not abled to reuse PR #1301.

QUALITY CHECKLIST

Copy link

codecov bot commented Dec 14, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e430330) 90.79% compared to head (0ee91ef) 90.79%.

Additional details and impacted files
@@ Coverage Diff @@ ## master #1423 +/- ## ======================================= Coverage 90.79% 90.79% ======================================= Files 342 342 Lines 11060 11060 Branches 1812 1812 ======================================= Hits 10042 10042 Misses 670 670 Partials 348 348 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@bkoelman bkoelman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

This looks good, but cannot be merged yet, because cleanup-code fails on ubuntu/macos -or- windows. The bug is tracked at https://youtrack.jetbrains.com/issue/RSRP-494002.

@bkoelman bkoelman mentioned this pull request Dec 15, 2023
4 tasks
@verdie-g
Copy link
Contributor Author

verdie-g commented Feb 8, 2024

Can we suppress the formatting on this file to avoid stalling that PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants