Skip to content

apply the attrs to the @attributes variable #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
voodoologic wants to merge 1 commit into
base: master
Choose a base branch
from
Open

apply the attrs to the @attributes variable #29

voodoologic wants to merge 1 commit into from

Conversation

@voodoologic
Copy link

@voodoologic voodoologic commented Jul 2, 2020

Supplying a pull request because it seems as though this line was a bug.

The code as written wouldn't take all my attributes provided in a an argument to #new.
jsmestad
jsmestad reviewed Jul 2, 2020
View reviewed changes
lib/jsonapi/consumer/helpers/dynamic_attributes.rb
@attributes ||= ActiveSupport::HashWithIndifferentAccess.new(attrs)

return @attributes unless attrs.present?
attrs.each do |key, value|
Copy link
Owner

@jsmestad jsmestad Jul 2, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be run, no?
Copy link
Author

@voodoologic voodoologic Jul 6, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes.

Needed for non-activerecord objects
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@voodoologic @jsmestad