Changed the path url encoding so that is should work with special chars ... #3
Conversation
…rs like german umlauts and such... new: $path = str_replace('%2F', '/', urlencode($path)); 
| Have you confirmed that having spaces encoded with '+' as urlencode does works? |
| OOps,... nope they don't :-( |
| Should be rawurlencode no urlencode |
| OK I'll close this one. Just open a new one with rawurlencode. |
| did it sorry |
| I haven't gotten the new pull request yet. Did you create a new one? |
| Yes, i have it, and on github i've Seen it also. I'm now out for the Summer, Best, Timo . Am 12.05.2012 um 18:39 schrieb Jimreply@reply.github.com:
|
| Hmm the changes don't seem to be reflected in this pull request and I haven't received notice of a new one. I'll just update it myself and close this request. Thanks for the fix. |
| Oh never mind it just showed up. Github is acting weird. OK Thanks. |
Changed the path url encoding so that is should work with special chars ...
2 participants
...like german umlauts and such...
new: $path = str_replace('%2F', '/', urlencode($path));