Skip to content

Conversation

@jerone
Copy link
Owner

@jerone jerone commented Aug 11, 2015

Fixes #68

@jerone
Copy link
Owner Author

jerone commented Aug 11, 2015

@darkred This PR contains a fix for your issue and other changes to GitHub new changes. I was hoping you could give this version a try to confirm that the fix works.

@darkred
Copy link
Contributor

darkred commented Aug 11, 2015

Yes, it's working ok now.
Just one thing: the filters now appears in a table which has borders (which makes the table rather confusing -- too many horizontal borders ):
screenshot
I'd definitely prefer the previous version where there were no borders at all.

Or alternatively, I'd suggest no borders -or dotted borders, i.e. more subtle ones-
between rows of subcategories that belong to the same category.
But keep the new maincategory+subcategories highlighting (when clicking a main category).
Here is a mockup for my suggestion:
http://i.imgur.com/5NPm3Iz.jpg

@jerone
Copy link
Owner Author

jerone commented Aug 12, 2015

Yes, it's working ok now.

Yeah thanks for testing 👍

Just one thing: [...]

I removed the previous theme because of GitHub removing it from every elements and switching to the current theme. Personally I prefer the new one, but I just want to precede GitHub when they remove the theme all together with all these updates to the GitHub site.

Just did a commit testing a design with arrows...
2015-08-12 23_26_53-github

Not sure yet about the best solution... will try your suggestion soon.

@jerone
Copy link
Owner Author

jerone commented Aug 12, 2015

Reminder for myself;

  • looks like not every comment on PR are counted as PR > comments
  • created tag aren't part of repo > tagged
@darkred
Copy link
Contributor

darkred commented Aug 13, 2015

Yeah thanks for testing

You're welcome.

Not sure yet about the best solution... will try your suggestion soon.

Great! 👍

@jerone
Copy link
Owner Author

jerone commented Aug 15, 2015

So I kind of settled on a combination of your and mine style suggestions:
2015-08-15 22_41_56-github
Besides the yellowish background color, font is now bold. I used dashed borders for sub filters, but kept the indention and arrows, because there are also sub sub filters.

@jerone jerone force-pushed the Github_News_Feed_Filter branch 2 times, most recently from 8f0207f to 2701888 Compare August 15, 2015 21:06
@jerone jerone force-pushed the Github_News_Feed_Filter branch from 2701888 to 1061c41 Compare August 15, 2015 21:08
@darkred
Copy link
Contributor

darkred commented Aug 15, 2015

It's great now. Thank you.

jerone added a commit that referenced this pull request Aug 16, 2015
🎬 Released new version GitHub News Feed Filter;
@jerone jerone merged commit 9ebb8e8 into master Aug 16, 2015
@jerone
Copy link
Owner Author

jerone commented Aug 16, 2015

@darkred Just merged this PR. Thanks for mentioning the issue, helping with debugging and testing. Mirrors should be synced very soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment