Remove Union and Optional Typehints and replace with pipe annotations #965
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Collaborator
| Perhaps you can answer this question #954 (comment) |
Contributor
IMO we should support these feature as long as they're in a supported Python version. Otherwise we're not really compatible with e.g. Python 3.9, if you can't use certain 3.9 features just because they're deprecated |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
I would assume that 3.9 is dropped at this point in time so I made some pretty significant changes to how annotations are written out in the main library using Ruff with UP045 and UP007 to help remove
typing.Optionalandtyping.Unionsince these items are now treated as deprecated after 3.9 if we did want backwards compatability for 3.9 we could add infrom __future__ import annotationsbut I would assume that 3.9 is dropped for good, hence this pull request being made by me.