Add support for XCFramework and Apple Silicon for tvOS Simulator #51
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This currently only generates XCFrameworks for iOS. Note that XCFramework can contain slices for all platforms. Currently, tvOS scripts are not generating all the necessary slices for simulator, so it needs to be updated.
* Update the tvOS scripts for all the dependencies to generate arm64 slices against AppleTVSimulator SDK. * Ensure xcframework now includes tvOS slices as well. * I primarily tried to follow the pattern for scripts, as I am not sure the exact reasoning behind all the arguments passed to configure. So there is likely a bit of refactoring required.
Closed
| Thank you @mofarajmandi ! Change merged. |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Summary
AppleTVSimulator SDK.
I primarily tried to follow the pattern for scripts, as I am not sure the exact reasoning behind all the arguments passed to configure. So there is likely a bit of refactoring required.
Next Steps:
This is likely very quick update, but I'd rather leave it for another PR.