Replace toLowerCase with lowercase to prevent locale-specific issues (e.g., Turkish) #77
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
fevziomurtekin changed the title toLowerCase with lowercase to prevent locale-specific issues (e.g., Turkish) 
adriangl reviewed Dec 6, 2024
There was a problem hiding this comment.
Hi! First of all, thanks a lot for the contribution!
Taking a look to the code it looks good to me! The idea is to use the default lowercase implementation so no language-specific conversion is performed, right? I've seen that it relies on Locale.ROOT if you don't specify a Locale
| Hey! Thank you for your feedback and for reviewing the code! 😊 Yes, by using Locale.ROOT with the lowercase method, we can handle such cases effectively. This ensures language-neutral behavior, avoiding issues like the Turkish-specific conversion of ‘I’ to ‘i. It provides a reliable way to perform lowercase transformations without being affected by the system’s default locale or specific language rules. |
adriangl approved these changes Dec 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
PR's key points
When using toLowerCase on the ANDROID_STRINGS string, the Turkish locale caused it to convert as androıd_strıngs (with a dotless “ı”). To prevent this issue, the string conversion was modified to explicitly specify a locale (e.g., Locale.ENGLISH), ensuring consistent behavior across different locales.
To more information => https://kotlinlang.org/api/core/kotlin-stdlib/kotlin.text/lowercase.html
How to review this PR?
Related Issues (delete if this does not apply)
Definition of Done